Fix codec size for large blocks #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marun
previously approved these changes
Dec 11, 2023
ceyonur
approved these changes
Dec 16, 2023
aaronbuchwald
approved these changes
Dec 18, 2023
StephenButtolph
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Initializing the codec as such:
https://github.com/ava-labs/coreth/blame/abde8d63c32d75b8e966e41eabea0051a2ffa50d/plugin/evm/message/codec.go#L24-L25
does not result in the codec's max slice marshal capacity increasing (see https://github.com/ava-labs/avalanchego/blob/master/codec/linearcodec/codec.go#L55-L65)
Fixes ava-labs/avalanchego#2454
Also this reduces the log level for retrying failed messages from peers to Debug so invalid responses cannot cause syncing clients to log @ info.
How this works
Calls
NewCustomMaxLength.How this was tested
Fixes the UT to encode a large block