Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark ourself as connected #543

Merged
merged 5 commits into from
May 13, 2024
Merged

Mark ourself as connected #543

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a1e5294
Mark ourself as connected
StephenButtolph May 2, 2024
6276b7e
fix log
StephenButtolph May 13, 2024
2e1d547
Merge branch 'master' into mark-self-as-connected
StephenButtolph May 13, 2024
b6ad1d6
cleanup
StephenButtolph May 13, 2024
c8e79a8
Merge branch 'mark-self-as-connected' of github.com:ava-labs/coreth i…
StephenButtolph May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions peer/network.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,12 +505,11 @@ func (n *network) Connected(ctx context.Context, nodeID ids.NodeID, nodeVersion
return nil
}

if nodeID == n.self {
log.Debug("skipping registering self as peer")
return nil
if nodeID != n.self {
// The legacy peer tracker doesn't expect to be connected to itself.
n.peers.Connected(nodeID, nodeVersion)
}
StephenButtolph marked this conversation as resolved.
Show resolved Hide resolved

n.peers.Connected(nodeID, nodeVersion)
return n.p2pNetwork.Connected(ctx, nodeID, nodeVersion)
}

Expand All @@ -524,7 +523,11 @@ func (n *network) Disconnected(ctx context.Context, nodeID ids.NodeID) error {
return nil
}

n.peers.Disconnected(nodeID)
if nodeID != n.self {
// The legacy peer tracker doesn't expect to be connected to itself.
n.peers.Disconnected(nodeID)
}

return n.p2pNetwork.Disconnected(ctx, nodeID)
}

Expand Down
Loading