Limit Accepted Block Cache + Store BlockID Index On-Disk #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Memory usage: |
|
alloc space: |
|
This reduced memory usage by ~50% (compared to what was seen on devnet): |
patrick-ogrady
changed the title
patrick-ogrady
commented
Oct 15, 2023
| return err | ||
| } | ||
| if err := batch.Put(PrefixBlockHeightKey(blk.Height()), blk.Bytes()); err != nil { | ||
| if err := batch.Put(PrefixBlockIDHeightKey(blk.ID()), bigEndianHeight); err != nil { |
There was a problem hiding this comment.
We need to store this on-disk now so that we can service historical Get requests. We make this tradeoff so that we can avoid db compaction (from storing blocks all over disk).
patrick-ogrady
commented
Oct 15, 2023
| return err | ||
| } | ||
| blkID := blk.ID() | ||
| if err := batch.Put(PrefixBlockHeightIDKey(blk.Height()), blkID[:]); err != nil { |
There was a problem hiding this comment.
We store a height lookup to avoid pulling entire blocks from disk to service historical queries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #475
We purposely store blocks separately from block metadata to make block shuffling on-disk less onerous (should be properly fixed with #553).
This should make implementing archival-required features much easier.