Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[x/programs] Improve runtime Config defaults #569

Merged
merged 20 commits into from
Oct 20, 2023
Merged

[x/programs] Improve runtime Config defaults #569

merged 20 commits into from
Oct 20, 2023

Conversation

hexfusion
Copy link
Contributor

@hexfusion hexfusion commented Oct 17, 2023 •
edited
Loading

This PR adds.

  • improved Config default handling
  • support for serializing the runtime ConfigBuilder
  • allow multiple instances of the runtime.Config to be passed to additional runtimes. Currently this would fail as the wasmtime.Config can only be used once per engine. This is important so we can ensure program to program calls use the same runtime configuration as the parent.
  • bumps defaultLimitMaxMemory from 16 to 18 pages. We found that 18 pages is required for all of our current examples.
  • Add testing only mode which allows for non production debug modes by enabling Wasi preview for the upcoming simulator work.
  • Removed maxFee from ConfigBuilder and added to Initialize()
  • renamed TransferUnits -> TransferUnitsTo

@hexfusion hexfusion changed the title Add support for serializing runtime config [x/programs] Add support for serializing runtime config Oct 17, 2023
@hexfusion hexfusion self-assigned this Oct 17, 2023
@hexfusion hexfusion added this to the v0.1.2 (Wasm Program VM Simulator) milestone Oct 17, 2023
@hexfusion hexfusion marked this pull request as ready for review October 17, 2023 20:35
@hexfusion hexfusion marked this pull request as draft October 17, 2023 22:50
@hexfusion hexfusion changed the title [x/programs] Add support for serializing runtime config [x/programs] Add support for serializing runtime ConfigBuilder Oct 18, 2023
@hexfusion hexfusion marked this pull request as ready for review October 18, 2023 16:04
exdx
exdx previously approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@exdx exdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hexfusion
Nit
2df7fc9 
Signed-off-by: Sam Batschelet <[email protected]>
@hexfusion
Nits
3268576 
Signed-off-by: Sam Batschelet <[email protected]>
@hexfusion
Improve debug documentation
30409ce 
Signed-off-by: Sam Batschelet <[email protected]>
@hexfusion
nit
a3085e6 
Signed-off-by: Sam Batschelet <[email protected]>
@hexfusion
Add maxUnits to runtime Initialize
f446970 
Signed-off-by: Sam Batschelet <[email protected]>
@hexfusion
Clarify transfer logic for meter
de05b74 
Signed-off-by: Sam Batschelet <[email protected]>
@hexfusion
Remove maxUnits from config
5f3924b 
Signed-off-by: Sam Batschelet <[email protected]>
@hexfusion
Make counter test more useful
9783e87 
Signed-off-by: Sam Batschelet <[email protected]>
@hexfusion
React to changes
85c8ccd 
Signed-off-by: Sam Batschelet <[email protected]>
@hexfusion
Clarify the need to recompile after debug
b7ee957 
Signed-off-by: Sam Batschelet <[email protected]>
@hexfusion
Clarify docs
64f405c 
Signed-off-by: Sam Batschelet <[email protected]>
@hexfusion
Cleanup config docs
cb6d57d 
Signed-off-by: Sam Batschelet <[email protected]>
@hexfusion hexfusion changed the title [x/programs] Add support for serializing runtime ConfigBuilder [x/programs] Improve runtime Config defaults Oct 20, 2023
exdx
exdx previously approved these changes Oct 20, 2023
View reviewed changes
@hexfusion
Update script to use DEBUG param
f376c37 
Signed-off-by: Sam Batschelet <[email protected]>
@patrick-ogrady patrick-ogrady merged commit bd56f04 into main Oct 20, 2023
21 checks passed
@patrick-ogrady patrick-ogrady deleted the config branch October 20, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrick-ogrady patrick-ogrady patrick-ogrady approved these changes

@exdx exdx exdx left review comments

@samliok samliok Awaiting requested review from samliok

Assignees

@hexfusion hexfusion

Labels
None yet
Projects
Platform Engineering Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hexfusion @patrick-ogrady @exdx