Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[x/programs] Set bulk memory support on debug mode #599

Merged
merged 6 commits into from
Nov 6, 2023
Merged

[x/programs] Set bulk memory support on debug mode #599

merged 6 commits into from
Nov 6, 2023

Conversation

samliok
Copy link
Contributor

@samliok samliok commented Nov 2, 2023

Was receiving this error when trying to run my compiled WASM(with IO) using debug mode.

 Error:       Received unexpected error:
                  WebAssembly translation error
     
                    Caused by:
                    Invalid input WebAssembly code at offset 40132: bulk memory support is not enabled

Added a check for the debugMode flag before we pass engineConfig into the wastime runtime.

hexfusion
hexfusion reviewed Nov 6, 2023
View reviewed changes
Copy link
Contributor

@hexfusion hexfusion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super minor nit then LGTM

x/programs/runtime/config.go Show resolved Hide resolved
x/programs/cmd/simulator/vm/actions/program_execute.go Outdated Show resolved Hide resolved
@hexfusion hexfusion added the wasm runtime Wasm runtime label Nov 6, 2023
@samliok samliok merged commit 70bd5ae into main Nov 6, 2023
22 checks passed
@samliok samliok deleted the bulk_mem branch November 6, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hexfusion hexfusion hexfusion approved these changes

@patrick-ogrady patrick-ogrady Awaiting requested review from patrick-ogrady

Assignees

@samliok samliok

Labels
wasm runtime Wasm runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samliok @hexfusion