[x/programs] Support key deletion #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
najeal
requested review from
samliok,
dboehm-avalabs and
richardpringle
as code owners
najeal
force-pushed
the
x-program-key-deletion
branch
from
432f624 to
dd4fed7
Compare
wasmlanche_sdk: update state module import - add delete function imports/pstate: add delete function
This function is using the new delete function being available from the state import module
najeal
force-pushed
the
x-program-key-deletion
branch
from
dd4fed7 to
ce0469d
Compare
richardpringle
requested changes
Feb 21, 2024
There was a problem hiding this comment.
Hey @najeal, thanks for the PR!
We're starting to get a little more strict with reviews here, so I apologize if you followed an existing pattern and I asked you to change something.
The change requests should be simple enough, though!
Feel free to let me know if you have any questions.
x/programs/examples/token_test.go
Outdated
| // check balance of alice | ||
| result, err = rt.Call(ctx, "get_balance", programIDPtr, alicePtr) | ||
| require.NoError(err) | ||
| require.Equal(int64(0), result[0]) |
There was a problem hiding this comment.
🤔, this test doesn't guarantee that the behaviour is as intended. We should check the state and ensure the key is no longer there.
delete function returns -1 when removing key from state fails
Access state db to verify key has been deleted after calling burn_from function
richardpringle
previously approved these changes
Feb 27, 2024
| require: None, | ||
| }, owner_key) | ||
| .expect("failed to burn alice tokens"); | ||
| assert_eq!(resp.error, None); |
|
@najeal, looks like you need to run |
richardpringle
approved these changes
Feb 29, 2024
|
@najeal, can you mention me in a comment if I forget about this? Everything looks good, we just need CI to pass |
|
@richardpringle CI passed 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
It enhances
stateimport module and usage addingdeletefunction to delete keys from the State.It updates the Token example to use the
deletefunction throught a new public program functionburn_from.Closes #590