feat: rawdb.InspectDatabaseOption
#111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARR4N
requested review from
a team,
darioush,
qdm12 and
ceyonur
and removed request for
a team
I'm happy to write one and PR it upstream too, let me know 😉 |
qdm12
reviewed
Feb 3, 2025
darioush
reviewed
Feb 3, 2025
Co-authored-by: Quentin McGaw <[email protected]> Signed-off-by: Arran Schlosberg <[email protected]>
|
|
If it's used then let's add the UT |
## Why this should be merged Add an example test for `InspectDatabase` with options. ## How this works See example code
qdm12
approved these changes
Feb 7, 2025
Co-authored-by: Quentin McGaw <[email protected]> Signed-off-by: Arran Schlosberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Allows for
ava-labs/corethequivalent modifications ofrawdb.InspectDatabase()through external logic injection.How this works
Variadic options to:
How this was tested
Testable example acting as a unit test.