Fix abi get inputs #1023
Merged
Fix abi get inputs #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* override network upgrades * genesis network upgrades defaults * fix conflicts * Update plugin/evm/vm.go
Co-authored-by: Darioush Jalali <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]>
…into replace-old-packers
marun
previously approved these changes
Dec 7, 2023
ceyonur
changed the base branch from
replace-old-packers
to
refactor-allowlist
Co-authored-by: Darioush Jalali <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]>
darioush
previously approved these changes
Dec 14, 2023
ceyonur
dismissed stale reviews from darioush and marun
The base branch was changed.
marun
approved these changes
Dec 15, 2023
darioush
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Fixes the enforced strict mode in Unpack decoder, which prevents using extra padded bytes in inputs.
More details: https://docs.soliditylang.org/en/latest/abi-spec.html#strict-encoding-mode
How this works
Adds a flag to toggle the strict mode. It is by default enabled, and DUpgrade disables it (strict mode is off in DUpgrade)
How this was tested
Added unit tests
How is this documented
Should be documented with Dupgrade changes