Add error handling to Warp #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minghinmatthewlam
requested review from
ceyonur,
darioush and
aaronbuchwald
as code owners
ceyonur
reviewed
Jan 25, 2024
Co-authored-by: Ceyhun Onur <[email protected]> Signed-off-by: minghinmatthewlam <[email protected]>
Co-authored-by: Ceyhun Onur <[email protected]> Signed-off-by: minghinmatthewlam <[email protected]>
darioush
approved these changes
Jan 25, 2024
marun
approved these changes
Jan 26, 2024
ceyonur
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Additional warp error handling
How this works
SourceChainIDandNetworkIDare correct.AppRequestif the node does not have the Warp message, it'll return an empty signature without an error, and ends up with log message sayingfailed to decompress signature, which is misleading implying getting the signature was okay and that the node did find the Warp message.How this was tested
n/a
How is this documented
n/a