Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve readability by removing extra var #1345

Merged
merged 6 commits into from
Sep 17, 2024

Conversation

ceyonur
Copy link
Collaborator

@ceyonur ceyonur commented Sep 16, 2024

Remove extra var to improve readability

@ceyonur ceyonur requested review from darioush and a team as code owners September 16, 2024 21:45
darioush
darioush previously approved these changes Sep 16, 2024
Base automatically changed from calc-base-fee-fix to master September 17, 2024 02:14
@ceyonur ceyonur dismissed darioush’s stale review September 17, 2024 02:14

The base branch was changed.

@ceyonur ceyonur enabled auto-merge (squash) September 17, 2024 02:15
@ceyonur ceyonur disabled auto-merge September 17, 2024 02:33
@ceyonur
Copy link
Collaborator Author

ceyonur commented Sep 17, 2024

This was approved but dismissed since the base branch is merged to master. There is no change, merging it now.

@ceyonur ceyonur merged commit 787b16b into master Sep 17, 2024
14 checks passed
@ceyonur ceyonur deleted the calc-base-fee-improve-readability branch September 17, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants