Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sp1 v4.0.0 #713

Merged
merged 4 commits into from
Jan 23, 2025
Merged

Add support for sp1 v4.0.0 #713

merged 4 commits into from
Jan 23, 2025

Conversation

0xSasaPrsic
Copy link
Member

@0xSasaPrsic 0xSasaPrsic commented Jan 15, 2025

Pull Request type

Add support for sp1 v4.0.0

Please add the labels corresponding to the type of changes your PR introduces:

  • Feature
  • Bugfix
  • Refactor
  • Format
  • Documentation
  • Testing
  • Other:

Description

Related Issues

Testing Performed

Checklist

  • I have performed a self-review of my own code.
  • The tests pass successfully with cargo test.
  • The code was formatted with cargo fmt.
  • The code compiles with no new warnings with cargo build --release and cargo build --release --features runtime-benchmarks.
  • The code has no new warnings when using cargo clippy.
  • If this change affects documented features or needs new documentation, I have created a PR with a documentation update.

@0xSasaPrsic 0xSasaPrsic changed the title Add support for sp1 v4-rc. Add support for sp1 v4.0.0 Jan 16, 2025
Copy link
Contributor

@Leouarz Leouarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve but for avail-rust api_dev.rs, some stuff were wrongly removed. After generation, we need to follow the instructions in DEV_NOTES.md

@0xSasaPrsic 0xSasaPrsic merged commit 305e82e into main Jan 23, 2025
16 checks passed
@0xSasaPrsic 0xSasaPrsic deleted the helios-sp1-v4 branch January 23, 2025 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants