Refactor SPI interfaces - use single common ConfigExtension to ServiceLoad all avaje-config extensions #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think this is what we want. Those methods were specifically on ConfigurationLog for a reason so its unclear why you moved them? If we where to make such a change we should communicate it clearly (and as such our github issue title should reflect all the change included in a PR). Why did you want to include this change? Resolved. |
rob-bygrave
reviewed
May 14, 2024
avaje-config/src/main/java/io/avaje/config/CoreConfigurationBuilder.java
Outdated
Show resolved
Hide resolved
rob-bygrave
reviewed
May 14, 2024
avaje-config/src/main/java/io/avaje/config/ConfigurationLog.java
Outdated
Show resolved
Hide resolved
As this is replaced by the generated one for ConfigExtension
rbygrave
changed the title
rbygrave
added a commit
that referenced
this pull request
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change for avaje-config extensions.
Makes one super interface
ConfigExtensionfor all the spi classes. All avaje-config extensions need to register with ServiceLoader using this interface rather than the specific one (like ConfigurationSource).All these extensions are loaded via ServiceLoader via the
ConfigExtensioninterface rather than making the 6 separate service loader calls for each specific extension interfaces.Requires avaje/avaje-spi-service#18