Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACP 118 - update handler ID and rename field #132

Merged
merged 4 commits into from
Aug 2, 2024
Merged

ACP 118 - update handler ID and rename field #132

merged 4 commits into from
Aug 2, 2024

Conversation

cam-schultz
Copy link
Contributor

@cam-schultz cam-schultz commented Jul 26, 2024 •
edited
Loading

  • Changes the canonical handler ID for SignatureRequests to 2 to avoid conflicting with AtomicTxGossipHandlerID
  • Changes SignatureRequest.data to SignatureRequest.message, since for all practical purposes, that field specifies a serialized Warp message to be signed.
  • Links to the reference implementation, and marks the ACP as "Implementable".

@cam-schultz cam-schultz mentioned this pull request Jul 26, 2024
Merged
@avalanche-foundation-admin avalanche-foundation-admin merged commit dc31593 into avalanche-foundation:main Aug 2, 2024
@cam-schultz cam-schultz deleted the acp-118-updates branch August 2, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avalanche-foundation-admin avalanche-foundation-admin avalanche-foundation-admin approved these changes

@michaelkaplan13 michaelkaplan13 michaelkaplan13 approved these changes

@StephenButtolph StephenButtolph Awaiting requested review from StephenButtolph

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cam-schultz @StephenButtolph @michaelkaplan13 @avalanche-foundation-admin