Remove JsonSchema, use System.Text.Json.Schema instead #164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for JSON schemas was recently added by @mili-tan in #150.
What I wasn't aware of is that C# already contains a built-in way of generating JSON schemas, fully compatible with System.Text.Json and its various attributes:
https://devblogs.microsoft.com/dotnet/system-text-json-in-dotnet-9
Schemas generated this way are already compatible with OllamaSharp since
format
is of typeobject?
.This pull request removes the JsonSchema class (which doesn't contain support for enums, fields, etc) and encourages the user to use
JsonSerializerOptions.Default.GetJsonSchemaAsNode
instead.Previously:
Now:
System.Text.Json.Schema can be used in frameworks prior to .NET 9 by installing the latest official System.Text.Json NuGet package.