fix: enable forceNewDeployment for ECS Task that is broken per #157 (#…

…159) Co-authored-by: yehuda-elementryx <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
aws-actions · Jan 28, 2021 · 4b6d445 · 4b6d445
1 parent c74a8ca
commit 4b6d445
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/dist/index.js b/dist/index.js
@@ -391,8 +391,8 @@ async function run() {
       waitForMinutes = MAX_WAIT_MINUTES;
     }
 
-    const forceNewDeployInput = core.getInput('force-new-deployment', { required: false }) || false;
-    const forceNewDeployment = forceNewDeployInput != undefined && (forceNewDeployInput.toLowerCase === 'true' || forceNewDeployInput);
+    const forceNewDeployInput = core.getInput('force-new-deployment', { required: false }) || 'false';
+    const forceNewDeployment = forceNewDeployInput.toLowerCase() === 'true';
 
     // Register the task definition
     core.debug('Registering the task definition');

diff --git a/index.js b/index.js
@@ -226,8 +226,8 @@ async function run() {
       waitForMinutes = MAX_WAIT_MINUTES;
     }
 
-    const forceNewDeployInput = core.getInput('force-new-deployment', { required: false }) || false;
-    const forceNewDeployment = forceNewDeployInput != undefined && (forceNewDeployInput.toLowerCase === 'true' || forceNewDeployInput);
+    const forceNewDeployInput = core.getInput('force-new-deployment', { required: false }) || 'false';
+    const forceNewDeployment = forceNewDeployInput.toLowerCase() === 'true';
 
     // Register the task definition
     core.debug('Registering the task definition');

diff --git a/index.test.js b/index.test.js
@@ -741,7 +741,7 @@ describe('Deploy to ECS', () => {
             .mockReturnValueOnce('cluster-789')          // cluster
             .mockReturnValueOnce('false')                // wait-for-service-stability
             .mockReturnValueOnce('')                     // wait-for-minutes
-            .mockReturnValueOnce(true);                  // force-new-deployment
+            .mockReturnValueOnce('true');                  // force-new-deployment
 
         await run();
         expect(core.setFailed).toHaveBeenCalledTimes(0);