Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS SDK for JavaScript version 3 (v3) Upgrade #148

Merged
merged 1 commit into from
Jan 31, 2024
Merged

AWS SDK for JavaScript version 3 (v3) Upgrade #148

merged 1 commit into from
Jan 31, 2024

Conversation

vincentclee
Copy link
Contributor

Issue #, if available:

Description of changes: Migrating your code to SDK for JavaScript V3

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@toha-nordic
Copy link
Contributor

Any chance this could get merged as well @taoyong-ty ? We are seeing warnings in workflows using this action.

@vincentclee
Copy link
Contributor Author

I rebased my changes

$ git rev-parse --short HEAD
642ba69
$ npm run test

> @aws-actions/[email protected] test
> mocha



  logName
    ✔ return the logGroupName and logStreamName from an ARN
    ✔ return undefined when the group and stream are null
    ✔ return undefined when the Arn is undefined

  githubInputs
    ✔ build basic parameters for codeBuild.startBuild
    ✔ a project name is required.
    ✔ can process env-vars-for-codebuild
    ✔ skips override when parameter is set to true
    ✔ can handle pull requests
    ✔ will not continue if there is no payload
    ✔ can handle configuring update call-rate
    ✔ can hide cloudwatch logs when the parameter is set to true

  inputs2Parameters
    ✔ build basic parameters for codeBuild.startBuild
    ✔ build override parameters for codeBuild.startBuild
    ✔ can process env-vars-for-codebuild
    ✔ can process disable-source-override
    ✔ can process disable-github-env-vars

  waitForBuildEndTime
    ✔ basic usages
got one
    ✔ waits for a build endTime **and** no cloud watch log events
    ✔ waits after being rate limited and tries again
    ✔ dies after getting an error from the aws sdk that isn't rate limiting

  buildSdk
    ✔ return the codebuild client when env variable AWS_CONTAINER_CREDENTIALS_FULL_URI exists
    ✔ return the codebuild client when env variable AWS_CONTAINER_CREDENTIALS_RELATIVE_URI exists


  22 passing (48ms)

Copy link
Contributor

@taoyong-ty taoyong-ty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the change!

@taoyong-ty taoyong-ty merged commit 6e37b5c into aws-actions:main Jan 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants