-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for sourceTypeOverride and sourceLocationOverride #165
Merged
taoyong-ty
merged 7 commits into
aws-actions:main
from
yamao-latte:feature/support-github-enterprise-source
Sep 10, 2024
Merged
feat: Add support for sourceTypeOverride and sourceLocationOverride #165
taoyong-ty
merged 7 commits into
aws-actions:main
from
yamao-latte:feature/support-github-enterprise-source
Sep 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces two new optional parameters: sourceTypeOverride: Allows overriding the source input type defined in the build project for the current build. Valid values include NO_SOURCE, CODECOMMIT, CODEPIPELINE, GITHUB, S3, BITBUCKET, and GITHUB_ENTERPRISE. sourceLocationOverride: Enables specifying a location that overrides the source location defined in the build project for the current build. These parameters provide flexibility in customizing the source settings for individual builds, without modifying the underlying build project configuration.
Please, review this PR. |
kadeboer
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could also really use this, and it looks sound to me.
I need this as well |
Thanks for making this change! taking a look now |
taoyong-ty
requested changes
Sep 4, 2024
taoyong-ty
approved these changes
Sep 10, 2024
taoyong-ty
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces two new optional parameters:
sourceTypeOverride: Allows overriding the source input type defined in the build project for the current build. Valid values include NO_SOURCE, CODECOMMIT, CODEPIPELINE, GITHUB, S3, BITBUCKET, and GITHUB_ENTERPRISE.
sourceLocationOverride: Enables specifying a location that overrides the source location defined in the build project for the current build.
These parameters provide flexibility in customizing the source settings for individual builds, without modifying the underlying build project configuration.
Issue #164
Description of changes:
sourceTypeOverride
parameter to allow users to override the source input type defined in the build project.action.yml
file to include thesourceTypeOverride
parameter with a description and set it as optional.sourceTypeOverride
parameter and pass its value to the CodeBuild API when starting a build.sourceLocationOverride
parameter to enable users to specify a custom source location for the current build.action.yml
file to include thesourceLocationOverride
parameter with a description and set it as optional.sourceLocationOverride
parameter and pass its value to the CodeBuild API when starting a build.sourceTypeOverride
andsourceLocationOverride
parameters, providing examples and explaining their usage.These changes enhance the flexibility and usability of the Action, allowing users to customize their build source settings on a per-build basis and enabling integration with various source providers, including GitHub Enterprise.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: