Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for sourceTypeOverride and sourceLocationOverride #165

Conversation

yamao-latte
Copy link
Contributor

This commit introduces two new optional parameters:

sourceTypeOverride: Allows overriding the source input type defined in the build project for the current build. Valid values include NO_SOURCE, CODECOMMIT, CODEPIPELINE, GITHUB, S3, BITBUCKET, and GITHUB_ENTERPRISE.
sourceLocationOverride: Enables specifying a location that overrides the source location defined in the build project for the current build.

These parameters provide flexibility in customizing the source settings for individual builds, without modifying the underlying build project configuration.

Issue #164

Description of changes:

  • Added sourceTypeOverride parameter to allow users to override the source input type defined in the build project.
    • Updated the action.yml file to include the sourceTypeOverride parameter with a description and set it as optional.
    • Modified the relevant code sections to handle the sourceTypeOverride parameter and pass its value to the CodeBuild API when starting a build.
  • Introduced sourceLocationOverride parameter to enable users to specify a custom source location for the current build.
    • Updated the action.yml file to include the sourceLocationOverride parameter with a description and set it as optional.
    • Modified the relevant code sections to handle the sourceLocationOverride parameter and pass its value to the CodeBuild API when starting a build.
  • Updated the README.md file to document the new sourceTypeOverride and sourceLocationOverride parameters, providing examples and explaining their usage.

These changes enhance the flexibility and usability of the Action, allowing users to customize their build source settings on a per-build basis and enabling integration with various source providers, including GitHub Enterprise.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

This commit introduces two new optional parameters:

sourceTypeOverride: Allows overriding the source input type defined in the build project for the current build. Valid values include NO_SOURCE, CODECOMMIT, CODEPIPELINE, GITHUB, S3, BITBUCKET, and GITHUB_ENTERPRISE.
sourceLocationOverride: Enables specifying a location that overrides the source location defined in the build project for the current build.

These parameters provide flexibility in customizing the source settings for individual builds, without modifying the underlying build project configuration.
@natanaelfiorilla-scopely

Please, review this PR.

Copy link

@kadeboer kadeboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could also really use this, and it looks sound to me.

@avx-rodmans
Copy link

I need this as well

@taoyong-ty
Copy link
Contributor

Thanks for making this change! taking a look now

code-build.js Show resolved Hide resolved
code-build.js Show resolved Hide resolved
@taoyong-ty taoyong-ty merged commit 287d617 into aws-actions:main Sep 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants