Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use AppSyncRealTimeClient Pod #330

Merged
merged 8 commits into from
Feb 27, 2020
Merged

Use AppSyncRealTimeClient Pod #330

merged 8 commits into from
Feb 27, 2020

Conversation

lawmicha
Copy link
Contributor

@lawmicha lawmicha commented Feb 19, 2020 •
edited
Loading

The consolidation work can be found here: awslabs/aws-mobile-appsync-sdk-ios#338

The code was then moved over and checked in at https://github.com/aws-amplify/aws-appsync-realtime-client-ios

pod has been published as 1.0.0 to represent the current state of things without major bug fix or changes, except the call outs would be

  • Interceptors are currently implemented by the consumer
  • A subscription factory class is also implemenented by the consumer.
  • both possible set of functionality that needs extra effort to be pulled into the shared package
  • A lot of places required making classes public

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lawmicha lawmicha changed the title Create AppSyncSubscriptionConnection Pod Create AppSyncSubscriptionClient Pod Feb 19, 2020
@lawmicha
Copy link
Contributor Author

datastore unit test failing on pod install

[!] Unable to find a specification for `AppSyncSubscriptionClient (~> 0.0.1)` depended upon by `AmplifyPlugins/AWSAPIPlugin`

This was referenced Feb 19, 2020
Merged
Closed
@lawmicha lawmicha requested a review from royjit February 19, 2020 18:36
@lawmicha lawmicha self-assigned this Feb 19, 2020
@lawmicha lawmicha changed the title Create AppSyncSubscriptionClient Pod Use AppSyncRealTimeClient Pod Feb 26, 2020
@lawmicha lawmicha merged commit 609d499 into master Feb 27, 2020
@lawmicha lawmicha deleted the api-subscription-migration-pod branch April 6, 2020 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@royjit royjit royjit approved these changes

Assignees

@lawmicha lawmicha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lawmicha @royjit