Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amplify API and AppSyncClient subscription code consolidation #327

Closed
wants to merge 3 commits into from

Conversation

lawmicha
Copy link
Contributor

@lawmicha lawmicha commented Feb 18, 2020

This first migrates code from AppSync client over to Amplify, replacing older subscription code. Any changes that were made in this package was ported back over to AppSync client. Since all files under subscription folder is identical, we should be able to create a swift package of cocoapod out of those files.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lawmicha
Copy link
Contributor Author

@lawmicha lawmicha marked this pull request as ready for review February 19, 2020 00:15
@lawmicha lawmicha changed the title [Draft] Amplify API and AppSyncClient subscription code consolidation Amplify API and AppSyncClient subscription code consolidation Feb 19, 2020
@lawmicha lawmicha requested a review from royjit February 19, 2020 00:33
@lawmicha
Copy link
Contributor Author

latest PR contains new pod #330

@lawmicha lawmicha closed this Feb 19, 2020
@lawmicha lawmicha deleted the api-subscription-migration branch April 27, 2020 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant