[Bug Fix][Amplify API] Fix the bug which fails to update the value to nil #519
Conversation
There was a problem hiding this comment.
Thanks for fixing this!
Overall lgtm, just a couple of requests:
- add a test to verify
nilis getting added correctly to the input dictionary (to avoid regressions in the future) - add some context about the issue in the PR description. Brief description of
dict[key] = nilvsdict.updateValue(nil, forKey: key)with a link to the main docs
…lify-ios into api/MutateNilBug Added a unit test
Podfile.lock
Outdated
| COCOAPODS: 1.9.3 | ||
| COCOAPODS: 1.9.2 |
There was a problem hiding this comment.
if 1.9.3 is already checked in, let's stick with that and upgrade ur local cocoapods version to 1.9.3 to avoid downgrades every time, then when u do a pod install, this should be updated back to 1.9.3 and the change will be reverted after you commit/push
| // | ||
|
|
||
| import XCTest | ||
| @testable import Amplify |
There was a problem hiding this comment.
not sure if Amplify is required in the tests below
There was a problem hiding this comment.
I just checked, Temporal isn't working without Amplify
| XCTAssertEqual(graphQLInput["status"] as? String, status.rawValue) | ||
|
|
||
| XCTAssertTrue(graphQLInput.keys.contains("updatedAt")) | ||
| XCTAssertNil(graphQLInput["updatedAt"]!) |
There was a problem hiding this comment.
do you need the force unwrap here?
There was a problem hiding this comment.
Ya, graphQLInput["updatedAt"] is an Any??. But XCTAssertNil() accepts Any?. So I need to unwrap a layer.
Description of changes:
This PR contains one line of code change, but fix the bug which fails to update the value to nil.
dict[key] = nilremoves the key from the dicthttps://developer.apple.com/documentation/swift/dictionary/2885650-subscript
dict.updateValue(nil, forKey: key)updates the value to nil without removing the keyhttps://developer.apple.com/documentation/swift/dictionary/3127179-updatevalue
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.