-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug Fix][Amplify API] Fix the bug which fails to update the value to nil #519
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ae89d12
debug Model-GraphQL.swift to fix update nil bug
ruiguoamz e3f7adc
debug Model-GraphQL.swift to fix update nil bug
ruiguoamz 606e528
added a unit test
ruiguoamz bd13b64
Merge branch 'api/MutateNilBug' of https://github.com/aws-amplify/amp…
ruiguoamz 542ad78
revert changes in Podfile.lock and Manifest.lock
ruiguoamz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 changes: 46 additions & 0 deletions
46
AmplifyPlugins/Core/AWSPluginsCoreTests/Model/Support/ModelGraphQLTests.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
// | ||
// Copyright 2018-2020 Amazon.com, | ||
// Inc. or its affiliates. All Rights Reserved. | ||
// | ||
// SPDX-License-Identifier: Apache-2.0 | ||
// | ||
|
||
import XCTest | ||
@testable import Amplify | ||
@testable import AmplifyTestCommon | ||
@testable import AWSPluginsCore | ||
|
||
class ModelGraphQLTests: XCTestCase { | ||
|
||
/// - Given: a `Model` type | ||
/// - When: | ||
/// - the model is of type `Post` | ||
/// - the model is initialized with value except `updatedAt` is set to nil | ||
/// - Then: | ||
/// - check if the generated GraphQLInput is valid input: | ||
/// - fields other than `updatedAt` has the correct value in them | ||
/// - `updatedAt` is nil | ||
func testPostModelToGraphQLInputSuccess() throws { | ||
let date: Temporal.DateTime = .now() | ||
let status = PostStatus.published | ||
let post = Post(id: "id", | ||
title: "title", | ||
content: "content", | ||
createdAt: date, | ||
draft: true, | ||
rating: 5.0, | ||
status: status) | ||
|
||
let graphQLInput = post.graphQLInput | ||
|
||
XCTAssertEqual(graphQLInput["title"] as? String, post.title) | ||
XCTAssertEqual(graphQLInput["content"] as? String, post.content) | ||
XCTAssertEqual(graphQLInput["createdAt"] as? String, post.createdAt.iso8601String) | ||
XCTAssertEqual(graphQLInput["draft"] as? Bool, post.draft) | ||
XCTAssertEqual(graphQLInput["rating"] as? Double, post.rating) | ||
XCTAssertEqual(graphQLInput["status"] as? String, status.rawValue) | ||
|
||
XCTAssertTrue(graphQLInput.keys.contains("updatedAt")) | ||
XCTAssertNil(graphQLInput["updatedAt"]!) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do you need the force unwrap here? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ya, graphQLInput["updatedAt"] is an |
||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if Amplify is required in the tests below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just checked, Temporal isn't working without Amplify