Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth.ts - Fixed typo #8598

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Auth.ts - Fixed typo #8598

merged 1 commit into from
Jul 28, 2021

Conversation

reberthkss
Copy link
Contributor

Description of changes

  • Fixed typo on disableSMS method name header

Description of how you validated changes

Just checking the comment

Checklist

  • PR description included
  • yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

- Fixed typo on method name
@reberthkss reberthkss requested a review from elorzafe as a code owner July 17, 2021 14:17
@codecov-commenter
Copy link

Codecov Report

Merging #8598 (8512b99) into main (0237962) will increase coverage by 4.65%.
The diff coverage is 39.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8598      +/-   ##
==========================================
+ Coverage   73.12%   77.78%   +4.65%     
==========================================
  Files         213      240      +27     
  Lines       13353    17116    +3763     
  Branches     2525     3651    +1126     
==========================================
+ Hits         9765    13314    +3549     
- Misses       3423     3677     +254     
+ Partials      165      125      -40     
Impacted Files Coverage Δ
...azon-cognito-identity-js/src/CognitoUserSession.js 100.00% <ø> (ø)
packages/amazon-cognito-identity-js/src/Client.js 52.04% <13.95%> (ø)
...ages/amazon-cognito-identity-js/src/CognitoUser.js 79.35% <30.00%> (ø)
...on-cognito-identity-js/src/AuthenticationHelper.js 100.00% <100.00%> (ø)
...es/amazon-cognito-identity-js/src/CookieStorage.js 92.85% <100.00%> (ø)
...amazon-cognito-identity-js/src/StorageHelper-rn.js 100.00% <100.00%> (ø)
...es/amazon-cognito-identity-js/src/StorageHelper.js 100.00% <100.00%> (ø)
packages/amazon-cognito-identity-js/src/index.js 100.00% <100.00%> (ø)
...es/Providers/AbstractConvertPredictionsProvider.ts 78.57% <0.00%> (-8.93%) ⬇️
...s/Providers/AbstractIdentifyPredictionsProvider.ts 78.57% <0.00%> (-8.93%) ⬇️
... and 156 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1c835b...8512b99. Read the comment docs.

@siegerts siegerts added the first-time-contributor The contribution is the first for this user in the repo label Jul 19, 2021
@siegerts siegerts requested a review from a team July 20, 2021 13:05
Copy link
Contributor

@manueliglesias manueliglesias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@elorzafe elorzafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @reberthkss

@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
first-time-contributor The contribution is the first for this user in the repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in the documentation of the function disableSMS in Auth.ts source file
6 participants