Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SyncEngine should inspect errors to determine retry advice #731

Closed
palpatim opened this issue Aug 19, 2020 · 1 comment
Closed

SyncEngine should inspect errors to determine retry advice #731

palpatim opened this issue Aug 19, 2020 · 1 comment
Labels
datastore Issues related to the DataStore category feature-request Request a new feature

Comments

@palpatim
Copy link
Member

As noted in the TODO in this code snippet https://github.com/aws-amplify/amplify-ios/blob/4cb4423a6eb3d46dc0caf4bf55392384b0e4acc8/AmplifyPlugins/DataStore/AWSDataStoreCategoryPlugin/Sync/RemoteSyncEngine+Retryable.swift#L31-L39

We do not currently respect error types when retrying sync errors; instead we always retry errors up to the limit, regardless of the incoming type. We should not retry error types that aren't considered retryable (e.g., 403, 404, etc)

@palpatim palpatim added datastore Issues related to the DataStore category enhancement labels Aug 19, 2020
palpatim added a commit that referenced this issue Aug 19, 2020
@drochetti drochetti added the pending-triage Issue is pending triage label Oct 10, 2020
@lawmicha lawmicha added feature-request Request a new feature and removed enhancement labels Jul 8, 2021
@lawmicha lawmicha removed the pending-triage Issue is pending triage label Apr 22, 2022
@lawmicha lawmicha added the p4 label Jun 8, 2022
@atierian
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datastore Issues related to the DataStore category feature-request Request a new feature
Projects
None yet
Development

No branches or pull requests

4 participants