Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): update storage upload APIs to use storage path #3574

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

phantumcode
Copy link
Contributor

Issue #

Description

  • Update Storage uploadData and uploadFile APIs to use StoragePath as a input parameter
  • Update unit tests for uploadData and uploadFile APIs
  • cleanup and update code comments and tests for downloadData and downloadFile APIs

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@phantumcode phantumcode requested a review from a team as a code owner March 19, 2024 17:18
@phantumcode phantumcode changed the base branch from main to feature/gen2_storage March 19, 2024 17:23
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 41.37931% with 34 lines in your changes missing coverage. Please review.

Project coverage is 68.16%. Comparing base (326ba60) to head (f51077f).

Files with missing lines Patch % Lines
...e/Operation/Request/StorageUploadDataRequest.swift 0.00% 13 Missing ⚠️
...e/Operation/Request/StorageUploadFileRequest.swift 0.00% 13 Missing ⚠️
...Operation/Request/StorageDownloadDataRequest.swift 0.00% 4 Missing ⚠️
...Operation/Request/StorageDownloadFileRequest.swift 0.00% 4 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                    @@
##           feature/gen2_storage    #3574      +/-   ##
========================================================
+ Coverage                 68.13%   68.16%   +0.02%     
========================================================
  Files                      1056     1081      +25     
  Lines                     35539    36546    +1007     
========================================================
+ Hits                      24215    24910     +695     
- Misses                    11324    11636     +312     
Flag Coverage Δ
API_plugin_unit_test 67.50% <ø> (ø)
AWSPluginsCore 66.90% <ø> (ø)
Amplify 47.42% <0.00%> (-0.25%) ⬇️
Analytics_plugin_unit_test 81.16% <ø> (ø)
Auth_plugin_unit_test 79.09% <ø> (+0.08%) ⬆️
CoreMLPredictions_plugin_unit_test 59.44% <ø> (ø)
DataStore_plugin_unit_test 82.31% <ø> (+0.99%) ⬆️
Geo_plugin_unit_test 70.75% <ø> (ø)
Logging_plugin_unit_test 62.87% <ø> (?)
Predictions_plugin_unit_test 37.16% <ø> (ø)
PushNotifications_plugin_unit_test 87.13% <ø> (ø)
Storage_plugin_unit_test 75.89% <100.00%> (+0.11%) ⬆️
unit_tests 68.16% <41.37%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phantumcode phantumcode merged commit 597473a into feature/gen2_storage Mar 19, 2024
78 checks passed
@phantumcode phantumcode deleted the feat/gen2_storage_upload branch March 19, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants