Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Storage): Adding integration tests for getURL, remove and list #3584

Merged
merged 1 commit into from
Mar 25, 2024
Merged

feat(Storage): Adding integration tests for getURL, remove and list #3584

merged 1 commit into from
Mar 25, 2024

Conversation

harsh62
Copy link
Member

@harsh62 harsh62 commented Mar 25, 2024 •
edited
Loading

Issue #

Description

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
    Integration Tests | Storage
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@harsh62 harsh62 requested a review from a team as a code owner March 25, 2024 13:35
@harsh62 harsh62 temporarily deployed to IntegrationTest March 25, 2024 13:36 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest March 25, 2024 13:36 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest March 25, 2024 13:36 — with GitHub Actions Inactive
@harsh62 harsh62 merged commit 540acc2 into feature/gen2_storage Mar 25, 2024
77 checks passed
@harsh62 harsh62 deleted the feat/gen2-integration-tests-get-list-remove branch March 25, 2024 17:58
@phantumcode phantumcode mentioned this pull request Apr 12, 2024
Merged
9 tasks
lawmicha pushed a commit that referenced this pull request Apr 16, 2024
@harsh62 @lawmicha
feat(Storage): Adding integration tests for getURL, remove and list (#…
16eb6f7 
…3584)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phantumcode phantumcode phantumcode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harsh62 @phantumcode