Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Auth): throw correct error for an unknown session error #3591

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

harsh62
Copy link
Member

@harsh62 harsh62 commented Apr 3, 2024

Issue #

Description

The PR is aimed at fixing fetchAuthSession API's error when an unknown HTTP error is thrown by the service.

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@harsh62 harsh62 requested a review from a team as a code owner April 3, 2024 16:02
@harsh62 harsh62 merged commit 68c7eff into main Apr 8, 2024
78 checks passed
@harsh62 harsh62 deleted the fix-auth-session-error branch April 8, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants