DataStore.save() with condition for remote storage #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawmicha
force-pushed
the
feature/datastore-conditional-update
branch
2 times, most recently
from
723ae70 to
d631c28
Compare
lawmicha
force-pushed
the
feature/datastore-conditional-update-cloud
branch
from
f51c05a to
72381d1
Compare
lawmicha
changed the title
lawmicha
commented
Mar 23, 2020
...ifyPlugins/DataStore/AWSDataStoreCategoryPluginIntegrationTests/DataStoreEndToEndTests.swift
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
AnyQueryPredicatefor encoding array of predicates, and custom Codable forQueryOperator.queryPredicateJsonin MutationEvent to allow decoding toQueryPredicatefor 1. sending API requests with condition input on create/update mutations, and 2. handle conditional mutations in theAWSMutationDatabaseAdapter: MutationEventIngester.AWSMutationDatabaseAdapterresolves conflicts for incoming candidate mutation events with conditions by saving the candidate. (does not drop/replace local with candidate, etc)DRAFT
This is written on top of existing PR for DataStore.save() with conditiion for local store DataStore.save() with condition #355 . we will merge this into 355 as single PR.
Need to check for successful response from API, and that the response contains graphQL Errors like "Conditional save failed", then retrieve from remote, and update local storage
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.