fix(api): propagate connectionLost error from websocket client to sync engine #3800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Breakage Report✅ No Public API Breaking Change detected |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3800 +/- ##
==========================================
+ Coverage 68.52% 68.69% +0.16%
==========================================
Files 1080 1080
Lines 37700 37692 -8
==========================================
+ Hits 25834 25892 +58
+ Misses 11866 11800 -66
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lawmicha
approved these changes
Aug 7, 2024
|
|
||
| await mockWebSocketClient.setStateToConnected() | ||
| Task { | ||
| try await Task.sleep(nanoseconds: 80 * 1_000_000) |
There was a problem hiding this comment.
why do we need delays? does it ensure a deterministic flow of events?
There was a problem hiding this comment.
yeah, as the websocket is mocked. here is trying to mock the events flow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
#3632
Description
When an app using the DataStore plugin switches from foreground to background, the network connection is aborted, and the
URLSessionTaskDelegatewill receive a connection lost error. This error should be propagated back to the remote sync engine to trigger a scheduling restart, ensuring all missing records are retrieved while the app is in the background without a connection.General Checklist
Given When Theninline code documentation and are named accordinglytestThing_condition_expectation()By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.