fix(api): storing cancelablles with actor methods in AppSyncRTC #3824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Breakage Report✅ No Public API Breaking Change detected |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3824 +/- ##
==========================================
- Coverage 68.62% 68.37% -0.25%
==========================================
Files 1080 1082 +2
Lines 37635 37731 +96
==========================================
- Hits 25827 25800 -27
- Misses 11808 11931 +123
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
API Breakage Report✅ No Public API Breaking Change detected |
lawmicha
previously approved these changes
Aug 23, 2024
lawmicha
reviewed
Aug 23, 2024
| @@ -425,24 +430,37 @@ extension AppSyncRealTimeClient { | |||
| } | |||
| } | |||
|
|
|||
| private func monitorHeartBeats(_ connectionAck: JSONValue?) { | |||
| internal func monitorHeartBeats(_ connectionAck: JSONValue?) { | |||
There was a problem hiding this comment.
nit: can probably omit internal as that is the default when no access level is specified
There was a problem hiding this comment.
thanks, will remove the modifier!
lawmicha
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
#3748
Description
The potential crash is caused by the non thread-safe
AnyCancellable.store(in:)API. This PR ensures that all cancellable properties are accessed within an isolated actor context.General Checklist
Given When Theninline code documentation and are named accordinglytestThing_condition_expectation()By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.