Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Predictions): rowIndex and columnIndex for cell #704

Merged
merged 6 commits into from
Aug 11, 2020

Conversation

ruiguoamz
Copy link
Contributor

@ruiguoamz ruiguoamz commented Aug 11, 2020

Description of changes:

Reference for this issue: #694

  • Added rowIndex and columnIndex for CELL struct.
  • Updated integration test testIdentifyTextTables

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ruiguoamz ruiguoamz added bug Something isn't working predictions Issues related to the Predictions category labels Aug 11, 2020
@ruiguoamz ruiguoamz added this to the 1.1.0 milestone Aug 11, 2020
@ruiguoamz ruiguoamz requested a review from wooj2 August 11, 2020 17:14
Added description for rowIndex and columnIndex bug fix
CHANGELOG.md Outdated
@@ -1,5 +1,11 @@
# Changelog

## unreleased
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to Unreleased

CHANGELOG.md Outdated

### Bug Fixes

- Fixed the bug where cell struct is missing rowIndex and columnIndex
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like this:?

- **Predictions**: Add rowIndex and columnIndex to Cell struct([#704](https://github.com/aws-amplify/amplify-ios/pull/704)

@ruiguoamz ruiguoamz merged commit 11ed503 into main Aug 11, 2020
@ruiguoamz ruiguoamz deleted the predictions/cell_location branch August 11, 2020 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working predictions Issues related to the Predictions category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants