fix(auth): parse and surface returned subscription @auth errors #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegocstn
force-pushed
the
diegocstn/autherrors
branch
from
ff07365 to
a7d585e
Compare
wooj2
reviewed
Oct 7, 2020
...yPlugin/Sync/MutationSync/OutgoingMutationQueue/ProcessMutationErrorFromCloudOperation.swift
Show resolved
Hide resolved
lawmicha
reviewed
Oct 7, 2020
AmplifyPlugins/API/AWSAPICategoryPlugin/Operation/AWSGraphQLSubscriptionOperation.swift
Outdated
Show resolved
Hide resolved
AmplifyPlugins/API/AWSAPICategoryPlugin/Operation/AWSGraphQLSubscriptionOperation.swift
Outdated
Show resolved
Hide resolved
Comment on lines
+12
to
+13
| extension AppSyncJSONValue { | ||
| static func toJSONValue(_ json: AppSyncJSONValue) -> JSONValue { |
There was a problem hiding this comment.
this looks good to me, i'm not sure if there's any other way around this? maybe there's a way to just decode the payload?["errors"] directly to [JSONValue.self] instead of this
diegocstn
force-pushed
the
diegocstn/autherrors
branch
from
a7d585e to
95f6aac
Compare
lawmicha
reviewed
Oct 8, 2020
AmplifyPlugins/API/AWSAPICategoryPlugin/Support/Utils/GraphQLResponseDecoder+DecodeError.swift
Outdated
Show resolved
Hide resolved
When a subscription fails due to an authorization issue, parse and surface AppSyncJSONValue errors in order to let DataStore recover
diegocstn
force-pushed
the
diegocstn/autherrors
branch
from
95f6aac to
72a0cd6
Compare
lawmicha
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a subscription fails due to an authorization issue, parse and surface AppSyncJSONValue errors
in order to let DataStore recover
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.