Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DataStore): Owner and Group Combined @auth #817

Merged
merged 3 commits into from
Oct 15, 2020
Merged

fix(DataStore): Owner and Group Combined @auth #817

merged 3 commits into from
Oct 15, 2020

Conversation

wooj2
Copy link
Contributor

@wooj2 wooj2 commented Oct 11, 2020

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@wooj2
Copy link
Contributor Author

wooj2 commented Oct 11, 2020

Related:
aws-amplify/amplify-android#860

@wooj2 wooj2 marked this pull request as ready for review October 12, 2020 00:08
@wooj2 wooj2 requested review from lawmicha and TrekSoft October 12, 2020 00:08
lawmicha
lawmicha approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@lawmicha lawmicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with suggestions, feel free to take what you like

AmplifyPlugins/Core/AWSPluginsCore/Model/Decorator/AuthRuleDecorator.swift Outdated Show resolved Hide resolved
AmplifyPlugins/Core/AWSPluginsCore/Model/Decorator/AuthRuleDecorator.swift Outdated Show resolved Hide resolved
AmplifyPlugins/Core/AWSPluginsCore/Model/Decorator/AuthRuleDecorator.swift Outdated Show resolved Hide resolved
...Plugins/Core/AWSPluginsCoreTests/Model/GraphQLRequest/GraphQLRequestOwnerAndGroupTests.swift Outdated Show resolved Hide resolved
AmplifyPlugins/Core/AWSPluginsCore/Model/Decorator/AuthRuleDecorator.swift Outdated Show resolved Hide resolved
AmplifyPlugins/Core/AWSPluginsCore/Model/Decorator/AuthRuleDecorator.swift Outdated Show resolved Hide resolved
@wooj2 wooj2 merged commit 8153149 into main Oct 15, 2020
@wooj2 wooj2 deleted the main-ogc branch October 15, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lawmicha lawmicha lawmicha approved these changes

@TrekSoft TrekSoft Awaiting requested review from TrekSoft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wooj2 @lawmicha