Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): rename conflicting name AWSAuthService to AWSCognitoAuthService #824

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

lawmicha
Copy link
Contributor

Issue #, if available:

Description of changes:
This is impacting some build systems when consuming AWSPluginsCore and AWSCognitoAuthPlugin
error:

Multiple commands produce 'AWSAuthService.o':
1) Target 'AWSPluginsCore' (project 'Pods') has compile command for Swift source files
2) Target 'AmplifyPlugins' (project 'Pods') has compile command for Swift source files

renamed file to the class in the file:

public enum AWSCognitoAuthService {

    case awsMobileClient(AWSMobileClient)

}

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lawmicha lawmicha requested a review from royjit October 14, 2020 20:41
@lawmicha lawmicha merged commit 523499a into main Oct 14, 2020
@lawmicha lawmicha deleted the fix/authservice-rename1 branch October 14, 2020 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants