Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move AWSServiceConfiguration Platform extension #832

Merged
merged 1 commit into from
Oct 16, 2020

Conversation

lawmicha
Copy link
Contributor

@lawmicha lawmicha commented Oct 16, 2020

Issue #, if available:

Description of changes:
In the fast lane script, there are one-off's that bump the version

 set_key_value(file: "AmplifyPlugins/Core/AWSPluginsCore/ServiceConfiguration/AmplifyAWSServiceConfiguration.swift", key: "version", value: version)

the problem was the version parameter was being picked up and replaced the type with the version number:
3b431c8#r43315436

And so, this code change is to move that extension over to it's own file

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lawmicha lawmicha requested a review from royjit October 16, 2020 21:03
@lawmicha lawmicha reopened this Oct 16, 2020
@lawmicha lawmicha merged commit fa2c7c9 into main Oct 16, 2020
@lawmicha lawmicha deleted the fix/version-bump branch October 16, 2020 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants