Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DataStore): Nested query predicates are not stored properly #905

Merged
merged 1 commit into from
Nov 23, 2020

Conversation

wooj2
Copy link
Contributor

@wooj2 wooj2 commented Nov 20, 2020

For Reference, android code:
https://github.com/aws-amplify/amplify-android/blame/12ec8e9819228f63bd677a0431a5ab191f79d9e1/core/src/main/java/com/amplifyframework/core/model/query/predicate/QueryPredicateGroup.java#L77

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@wooj2 wooj2 requested a review from drochetti November 20, 2020 23:51
@codecov
Copy link

codecov bot commented Nov 21, 2020

Codecov Report

Merging #905 (f921257) into main (e2fe056) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #905      +/-   ##
==========================================
- Coverage   64.89%   64.89%   -0.01%     
==========================================
  Files         862      862              
  Lines       34182    34178       -4     
==========================================
- Hits        22182    22179       -3     
+ Misses      12000    11999       -1     
Flag Coverage Δ
API_plugin_unit_test 62.49% <ø> (-0.08%) ⬇️
Analytics_plugin_unit_test 72.38% <ø> (ø)
Auth_plugin_unit_test 15.79% <ø> (ø)
DataStore_plugin_unit_test 83.03% <ø> (ø)
Predictions_plugin_unit_test 42.11% <ø> (ø)
Storage_plugin_unit_test 74.74% <ø> (ø)
build_test_amplify 64.29% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...fy/Categories/DataStore/Query/QueryPredicate.swift 0.00% <0.00%> (ø)
...n/Operation/AWSGraphQLOperation+APIOperation.swift 50.84% <0.00%> (-6.78%) ⬇️
.../DataStore/Model/Internal/Schema/ModelSchema.swift 85.29% <0.00%> (-2.95%) ⬇️
...in/Operation/AWSGraphQLSubscriptionOperation.swift 70.08% <0.00%> (+1.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2fe056...f921257. Read the comment docs.

Copy link
Contributor

@drochetti drochetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes more sense now! thanks for catching that

@wooj2 wooj2 merged commit 580255a into main Nov 23, 2020
@wooj2 wooj2 deleted the bug/queryPred branch November 23, 2020 22:25
@wooj2
Copy link
Contributor Author

wooj2 commented Nov 23, 2020

makes more sense now! thanks for catching that

Shout out to @richardmcclellan for helping me debug this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants