Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DataStore): SyncMutationToCloudOperationTests thread sanitizer bug #915

Merged
merged 1 commit into from
Nov 28, 2020

Conversation

wooj2
Copy link
Contributor

@wooj2 wooj2 commented Nov 27, 2020

Addresses bug filed here:
#914

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@wooj2 wooj2 added datastore Issues related to the DataStore category bug Something isn't working labels Nov 27, 2020
@codecov
Copy link

codecov bot commented Nov 27, 2020

Codecov Report

Merging #915 (652aa3a) into main (ff776df) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #915      +/-   ##
==========================================
- Coverage   67.27%   67.27%   -0.01%     
==========================================
  Files         895      895              
  Lines       35372    35372              
==========================================
- Hits        23796    23795       -1     
- Misses      11576    11577       +1     
Flag Coverage Δ
API_plugin_unit_test 62.49% <ø> (-0.08%) ⬇️
Analytics_plugin_unit_test 72.38% <ø> (ø)
Auth_plugin_unit_test 48.62% <ø> (ø)
DataStore_plugin_unit_test 83.03% <100.00%> (ø)
Predictions_plugin_unit_test 49.49% <ø> (ø)
Storage_plugin_unit_test 74.74% <ø> (ø)
build_test_amplify 63.13% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ationQueue/SyncMutationToCloudOperationTests.swift 93.71% <100.00%> (ø)
...lugin/Operation/AWSAPIOperation+APIOperation.swift 78.37% <0.00%> (-5.41%) ⬇️
...s/AWSHubPlugin/Internal/HubChannelDispatcher.swift 94.11% <0.00%> (-2.95%) ⬇️
.../DataStore/Model/Internal/Schema/ModelSchema.swift 85.29% <0.00%> (+2.94%) ⬆️
Amplify/Categories/Hub/HubFilter.swift 57.89% <0.00%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff776df...652aa3a. Read the comment docs.

@wooj2 wooj2 merged commit d49854f into main Nov 28, 2020
@wooj2 wooj2 deleted the fix/syncMutationcloudOperationTest branch November 28, 2020 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working datastore Issues related to the DataStore category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants