fix(API): subscription cancel unit test failing intermittently #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #927 +/- ##
==========================================
+ Coverage 69.00% 69.10% +0.09%
==========================================
Files 898 898
Lines 36697 36819 +122
==========================================
+ Hits 25324 25442 +118
- Misses 11373 11377 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
lawmicha
approved these changes
Dec 2, 2020
...ins/API/AWSAPICategoryPluginTests/Operation/AWSGraphQLSubscriptionOperationCancelTests.swift
Outdated
Show resolved
Hide resolved
...ins/API/AWSAPICategoryPluginTests/Operation/AWSGraphQLSubscriptionOperationCancelTests.swift
Outdated
Show resolved
Hide resolved
...ins/API/AWSAPICategoryPluginTests/Operation/AWSGraphQLSubscriptionOperationCancelTests.swift
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing start/stop for datastore, I noticed these tests were failing because the
SubscriptionConnectionFactorywas able to throw an exception and fail, prior tocancel()execution happening. When this happens, theoperationends up in afinishedstate rather than the expectedcanceledstate.So.. to remedy this, I re-worked these tests by using the existing
MockSubscriptionConnectionFactoryto test various cases.To reproduce the unexpected behavior, revert these changes, and add a
sleep(2)right before the call tooperation.cancel(), then run the test.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.