Fixes memory leaks in IoT #1175
Conversation
| @@ -639,6 +672,12 @@ - (void)openStreams:(id)sender | |||
| [defaultRunLoopTimer invalidate]; | |||
|
|
|||
| if (!self.runLoopShouldContinue ) { | |||
|
|
|||
| if (self.connectionAgeTimer != nil ) { | |||
There was a problem hiding this comment.
@cbommas, your earlier suggestion to simplify this was correct as this method will be called already on the correct thread.
| // NOTE: This does not work as intended. The reconnection attempt is always done on the reconnect thread | ||
| // but the timer needs to be invalidated on the streams thread to ensure memory is released. | ||
| // However, as currently implemented a switch to the streams thread here to clean this up is always beaten to the | ||
| // invalidation by other events which are are already being processed on the streams thread. | ||
| [self.connectionAgeTimer invalidate]; |
There was a problem hiding this comment.
As noted this doesn't really work but other code avoids a memory leak. Ideally, this would have code to switch threads to clean up correctly but I left this alone for now as by the time a thread switch got control another event had already done the cleanup. I can update PR to have the thread switch if desired.
There was a problem hiding this comment.
For this change, rather than doing a thread switch, lets just remove this code, as it is handled in one of the other events.
|
Can we break this PR up into two separate ones? There are changes to the IOT code and the Core code. The challenge I have with AWSCore code changes is that we had to make the change to not invalidate the session due to crashes ( see #913). We will have to dive deeper on this. For the IOT changes, I will be testing them and prepping for release, pending the test results. |
Similar to earlier PR with another memory leak fixed and target most recent SDK version.
After removing an
AWSIoTDataManager, theAWSIoTDataManager,AWSIoTMQTTClient,AWSURLSessionManagerand other related entities were leaked.This fixes a retain cycle between the
AWSIoTMQTTClientwhere it held a strong reference to theassociatedObjecttheAWSIoTDataManagerwhich was holding a strong reference to themqttClient. This makes theassociatedObjectreference weak.If an
AWSIoTDataManagerwas disconnected before theconnectionAgeInSecondsexceeded theminimumConnectionTimetheconnectionAgeTimerwas never invalidated and held a strong reference to theAWSIoTMQTTClient(e.g.selfpassed to the timer on creation of the timer). This fixes the issue by issuing aninvalidateto the timer on the correct thread in the event the user requests a disconnect before reaching theminimumConnectionTime.The
AWSURLSessionManagercreates and passesselfto anNSURLSessionbut never invalidated the session to release the strong reference toself.AWSNetworkingcould be released but theAWSURLSessionManagerleaked being held by theNSURLSession. This is fixed by having theAWSNetworkinglet theAWSURLSessionManagerknow it needs to invalidate the session when it is being released, as none of them should be needed after theAWSNetworkingcreating them is released.The
reconnectTimerwas invalidated on whatever threaddisconnectwas called on rather than thereconnectThreadcausing a memory leak; this is fixed by having thereconnectTimerinvalidated on the correct thread.