Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(S3): Add TransferAcceleration test #3460

Merged
merged 1 commit into from
Mar 5, 2021

Conversation

palpatim
Copy link
Member

@palpatim palpatim commented Mar 5, 2021

Description of changes: Validates that S3 SDK virtual-host style addressing works as expected for Transfer Acceleration-enabled buckets. Steps:

  • Obtain the normal credentials provider
  • Create a new custom endpoint with the URL string: "https://s3-accelerate.amazonaws.com"
  • Register an S3 client with that endpoint
  • Specify the transfer-accelerated bucket in requests

Check points:

  • Added new tests to cover change, if needed
  • All unit tests pass
  • All integration tests pass
  • [ ] Updated CHANGELOG.md
  • [ ] Documentation update for the change if required
  • PR title conforms to conventional commit style

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@palpatim palpatim merged commit 2e5cd63 into main Mar 5, 2021
@palpatim palpatim deleted the palpatim.test.s3.add-transfer-accel-test branch March 5, 2021 20:52
gabek pushed a commit to KeepSafe/aws-sdk-ios that referenced this pull request Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants