Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(IoT): enables IoT configuration with awsconfiguration.json #3815

Merged
merged 2 commits into from
Oct 14, 2021

Conversation

brennanMKE
Copy link
Contributor

@brennanMKE brennanMKE commented Oct 11, 2021

Issue #, if available:

#3814

Description of changes:

IoT settings can now be read from awsconfiguration.json.

Check points:

  • Added new tests to cover change, if needed
  • All unit tests pass
  • All integration tests pass
  • Updated CHANGELOG.md
  • Documentation update for the change if required
  • PR title conforms to conventional commit style

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@brennanMKE brennanMKE self-assigned this Oct 11, 2021
@brennanMKE brennanMKE changed the title Enables IoT configuration with awsconfiguration.json feat(IoT): enables IoT configuration with awsconfiguration.json Oct 13, 2021
Brennan Stehling added 2 commits October 13, 2021 16:52
The section below can be added to awsconfiguration.json to use AWSIoT.default() from Swift.

```json
"IoT": {
    "Default": {
        "Region": "us-east-1",
        "Endpoint": "https://CHANGE_ME-ats.iot.us-east-1.amazonaws.com"
    }
},
"IoTManager": {
    "Default": {
        "Region": "us-east-1",
        "Endpoint": "https://CHANGE_ME-ats.iot.us-east-1.amazonaws.com"
    }
},
```
Copy link
Contributor

@ameter ameter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brennanMKE brennanMKE merged commit 049533c into main Oct 14, 2021
@brennanMKE brennanMKE deleted the stehlib.iot.3814 branch October 14, 2021 20:11
gabek pushed a commit to KeepSafe/aws-sdk-ios that referenced this pull request Aug 31, 2023
…amplify#3815)

* feat(IoT): supports reading settings from awsconfiguration.json
* updates CHANGELOG.md

The section below can be added to awsconfiguration.json to use AWSIoT.default() from Swift.

```json
"IoT": {
    "Default": {
        "Region": "us-east-1",
        "Endpoint": "https://CHANGE_ME-ats.iot.us-east-1.amazonaws.com"
    }
},
"IoTManager": {
    "Default": {
        "Region": "us-east-1",
        "Endpoint": "https://CHANGE_ME-ats.iot.us-east-1.amazonaws.com"
    }
},
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants