Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Optional Shadow Topic Subscription #2039 fix. #3875

Closed
wants to merge 1 commit into from

Conversation

karasahinemre
Copy link

@karasahinemre karasahinemre commented Nov 11, 2021

Issue #, if available:

#2039

Description of changes:

Github Optional Shadow Topic Subscription #2039 fix. enableIgnoreDeletes and enableIgnoreRejecteds flags added for decreasing subscribed topic count.

Check points:

  • Added new tests to cover change, if needed - No need to add new tests.
  • All unit tests pass
  • All integration tests pass
  • Updated CHANGELOG.md
  • Documentation update for the change if required
  • PR title conforms to conventional commit style

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…eIgnoreDeletes and enableIgnoreRejecteds flags added for decreasing subscribed topic count.
@karasahinemre karasahinemre requested a review from a team November 11, 2021 14:36
@thisisabhash
Copy link
Member

Thank you for raising the PR. We are currently discussing this within our team and will post here with further updates.

@karasahinemre
Copy link
Author

Hi @thisisabhash,

Any updates?

@brennanMKE brennanMKE self-requested a review December 17, 2021 18:32
@brennanMKE
Copy link
Contributor

@karasahinemre Hi Emre, could you reach out to us on Discord so we can discuss this?

@karasahinemre
Copy link
Author

karasahinemre commented Dec 17, 2021

Hi,

We can do this on this Monday if it's okay for you. Can you share your time zone? So, we can find a suitable time for both of us.

@karasahinemre
Copy link
Author

Or It would be more convenient if you send a time that suits you and detailed contact information.

@karasahinemre
Copy link
Author

Hi,

How can we proceed?

@karasahinemre
Copy link
Author

Hi,

@brennanMKE, @awsmobilesdk we are waiting for your reply.

Please let me know when you are available.

@karasahinemre
Copy link
Author

Hi @brennanMKE,

Any updates?

@brennanMKE
Copy link
Contributor

@karasahinemre You should have received an email update last week. To summarize, we do not currently support this feature in the SDK so you can use one of the following options.

Fork SDK

You can fork the SDK and then use it to create a binary framework with our instructions on Local Development. When there are new releases of the SDK you can rebase and rebuild to get new builds of the binary SDK with each release. If you have a CI/CD system in place you could automate this update with releases we publish to GitHub using the GitHub API for Releases.

Experiment with new Swift SDK

You can look into using the AWS SDK for Swift (Developer Preview) which is being prepared for GA release. You can see it produces many build products for AWS IoT which covers more services and features than the current SDK. In AWSIoTDataPlane you can find IotDataPlaneClient has shadow support.

In the short term you could use your forked version and once the new Swift SDK reaches GA release you could migrate to it.

@brennanMKE brennanMKE closed this Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants