Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(IoT): Updating keepAliveTimeInterval attribute comment #5285

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

sebaland
Copy link
Member

@sebaland sebaland commented Apr 9, 2024

Issue #, if available:

Description of changes:

The default value for keepAliveTimeInterval was updated to 300 seconds in version 2.6.6, but its corresponding attribute comment was not.

Check points:

  • Added new tests to cover change, if needed
  • All unit tests pass
  • All integration tests pass
  • Updated CHANGELOG.md
  • Documentation update for the change if required
  • PR title conforms to conventional commit style

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sebaland sebaland requested review from awsmobilesdk and a team as code owners April 9, 2024 18:21
@sebaland sebaland temporarily deployed to IntegrationTest April 9, 2024 18:22 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 9, 2024 18:22 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 9, 2024 18:22 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 9, 2024 18:22 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 9, 2024 18:22 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 9, 2024 18:22 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 9, 2024 18:23 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 9, 2024 18:23 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 9, 2024 18:23 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 9, 2024 18:23 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 9, 2024 18:23 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 9, 2024 18:23 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 9, 2024 18:23 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 9, 2024 18:23 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 9, 2024 18:23 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 9, 2024 18:23 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 9, 2024 18:23 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 9, 2024 18:23 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 9, 2024 18:23 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 9, 2024 18:23 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 9, 2024 18:23 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 9, 2024 18:23 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 9, 2024 18:23 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest April 9, 2024 18:23 — with GitHub Actions Inactive
@sebaland sebaland merged commit 94eeb73 into main Apr 9, 2024
25 of 26 checks passed
@sebaland sebaland deleted the ruisebas/fix-iot-doc branch April 9, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants