Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(MobileClient): Fixing a crash when attempting to use HostedUI #5316

Merged
merged 2 commits into from
May 3, 2024
Merged

fix(MobileClient): Fixing a crash when attempting to use HostedUI #5316

merged 2 commits into from
May 3, 2024

Conversation

sebaland
Copy link
Member

@sebaland sebaland commented May 3, 2024 •
edited
Loading

Issue #, if available:

Description of changes:

This PR fixes a crash when attempting to use HostedUI.

It was caused by the upgrade from SFAuthenticationSession to ASWebAuthenticationSession in our bump to iOS 12, as ASWebAuthenticationSession does not allow the scheme to contain special characters.

Fixing it by validating the scheme first as we do in other methods dealing with ASWebAuthenticationSession

Check points:

  • Added new tests to cover change, if needed
  • All unit tests pass
  • All integration tests pass
  • Updated CHANGELOG.md
  • Documentation update for the change if required
  • PR title conforms to conventional commit style

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sebaland sebaland requested review from awsmobilesdk and a team as code owners May 3, 2024 15:33
@sebaland sebaland temporarily deployed to IntegrationTest May 3, 2024 15:33 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 3, 2024 15:33 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 3, 2024 15:43 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 3, 2024 16:14 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 3, 2024 16:55 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 3, 2024 16:55 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 3, 2024 16:55 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 3, 2024 16:55 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 3, 2024 16:55 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 3, 2024 16:55 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 3, 2024 16:55 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 3, 2024 16:55 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 3, 2024 16:55 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 3, 2024 16:55 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 3, 2024 16:55 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 3, 2024 16:55 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 3, 2024 16:55 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 3, 2024 16:55 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 3, 2024 16:55 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 3, 2024 16:55 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 3, 2024 16:55 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 3, 2024 16:55 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 3, 2024 16:55 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 3, 2024 16:55 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 3, 2024 16:55 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 3, 2024 16:55 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 3, 2024 16:55 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 3, 2024 16:55 — with GitHub Actions Inactive
@sebaland sebaland temporarily deployed to IntegrationTest May 3, 2024 16:55 — with GitHub Actions Inactive
@sebaland sebaland merged commit 7192432 into main May 3, 2024
67 checks passed
@sebaland sebaland deleted the fix/auth_callback branch May 3, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisabhash thisisabhash thisisabhash approved these changes

@harsh62 harsh62 harsh62 approved these changes

@awsmobilesdk awsmobilesdk Awaiting requested review from awsmobilesdk awsmobilesdk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebaland @harsh62 @thisisabhash