Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWSSQS Update models to latest #5328

Conversation

awsmobilesdk
Copy link
Collaborator

AWSSQS Update models to latest

@awsmobilesdk awsmobilesdk requested a review from a team as a code owner May 8, 2024 18:17
@awsmobilesdk awsmobilesdk temporarily deployed to IntegrationTest May 8, 2024 18:17 — with GitHub Actions Inactive
@awsmobilesdk awsmobilesdk temporarily deployed to IntegrationTest May 8, 2024 18:17 — with GitHub Actions Inactive
@awsmobilesdk awsmobilesdk temporarily deployed to IntegrationTest May 8, 2024 18:17 — with GitHub Actions Inactive
@awsmobilesdk awsmobilesdk temporarily deployed to IntegrationTest May 8, 2024 18:17 — with GitHub Actions Inactive
@awsmobilesdk awsmobilesdk temporarily deployed to IntegrationTest May 8, 2024 18:17 — with GitHub Actions Inactive
@awsmobilesdk awsmobilesdk temporarily deployed to IntegrationTest May 8, 2024 18:17 — with GitHub Actions Inactive
@awsmobilesdk awsmobilesdk temporarily deployed to IntegrationTest May 8, 2024 18:17 — with GitHub Actions Inactive
@awsmobilesdk awsmobilesdk temporarily deployed to IntegrationTest May 8, 2024 18:17 — with GitHub Actions Inactive
@awsmobilesdk awsmobilesdk temporarily deployed to IntegrationTest May 8, 2024 18:17 — with GitHub Actions Inactive
@awsmobilesdk awsmobilesdk temporarily deployed to IntegrationTest May 8, 2024 18:17 — with GitHub Actions Inactive
@awsmobilesdk awsmobilesdk temporarily deployed to IntegrationTest May 8, 2024 18:17 — with GitHub Actions Inactive
@awsmobilesdk awsmobilesdk temporarily deployed to IntegrationTest May 8, 2024 18:17 — with GitHub Actions Inactive
@awsmobilesdk awsmobilesdk temporarily deployed to IntegrationTest May 8, 2024 18:17 — with GitHub Actions Inactive
@awsmobilesdk awsmobilesdk temporarily deployed to IntegrationTest May 8, 2024 18:18 — with GitHub Actions Inactive
@awsmobilesdk awsmobilesdk temporarily deployed to IntegrationTest May 8, 2024 18:18 — with GitHub Actions Inactive
@awsmobilesdk awsmobilesdk temporarily deployed to IntegrationTest May 8, 2024 18:18 — with GitHub Actions Inactive
@awsmobilesdk awsmobilesdk temporarily deployed to IntegrationTest May 8, 2024 18:18 — with GitHub Actions Inactive
@awsmobilesdk awsmobilesdk temporarily deployed to IntegrationTest May 8, 2024 18:18 — with GitHub Actions Inactive
@awsmobilesdk awsmobilesdk temporarily deployed to IntegrationTest May 8, 2024 18:18 — with GitHub Actions Inactive
@awsmobilesdk awsmobilesdk temporarily deployed to IntegrationTest May 8, 2024 18:18 — with GitHub Actions Inactive
@awsmobilesdk awsmobilesdk temporarily deployed to IntegrationTest May 8, 2024 18:18 — with GitHub Actions Inactive
@awsmobilesdk awsmobilesdk temporarily deployed to IntegrationTest May 8, 2024 18:18 — with GitHub Actions Inactive
Copy link
Contributor

@lawmicha lawmicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWSSQSTests
testGetQueueAttributesRequestFailure, (([@"AWS.SimpleQueueService.NonExistentQueue" isEqualToString:task.error.userInfo[@"Code"]]) is true) failed
/Users/runner/work/aws-sdk-ios/aws-sdk-ios/AWSSQSTests/AWSSQSTests.m:80

      XCTAssertEqual(task.error.code, AWSSQSErrorQueueDoesNotExist);
      XCTAssertTrue([@"AWS.SimpleQueueService.NonExistentQueue" isEqualToString:task.error.userInfo[@"Code"]]);
      XCTAssertTrue([@"The specified queue does not exist for this wsdl version." isEqualToString:task.error.userInfo[@"Message"]]);

testGetQueueAttributesRequestFailure, (([@"The specified queue does not exist for this wsdl version." isEqualToString:task.error.userInfo[@"Message"]]) is true) failed
/Users/runner/work/aws-sdk-ios/aws-sdk-ios/AWSSQSTests/AWSSQSTests.m:81

      XCTAssertTrue([@"AWS.SimpleQueueService.NonExistentQueue" isEqualToString:task.error.userInfo[@"Code"]]);
      XCTAssertTrue([@"The specified queue does not exist for this wsdl version." isEqualToString:task.error.userInfo[@"Message"]]);
      return nil;

The integration tests continue to fail on AWSSQS so most likely it's related to the changes. the failing test might be asserting on an error code or message that was changed.

@sebaland
Copy link
Member

sebaland commented Jul 8, 2024

Closing in favour of #5368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants