Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Fixing S3's integration tests due to GetTorrentObject going EoS #5421

Merged
merged 1 commit into from
Aug 8, 2024
Merged

test: Fixing S3's integration tests due to GetTorrentObject going EoS #5421

merged 1 commit into from
Aug 8, 2024

Conversation

ruisebas
Copy link
Member

@ruisebas ruisebas commented Aug 7, 2024

Description of changes:
GetObjectTorrent is reaching EoS and the integration tests are failing because of that.

Check points:

  • Added new tests to cover change, if needed
  • All unit tests pass
  • All integration tests pass
  • Updated CHANGELOG.md
  • Documentation update for the change if required
  • PR title conforms to conventional commit style

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ruisebas ruisebas temporarily deployed to IntegrationTest August 7, 2024 20:44 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest August 7, 2024 20:44 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest August 7, 2024 20:44 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest August 7, 2024 20:44 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest August 7, 2024 20:44 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest August 7, 2024 20:44 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest August 7, 2024 20:44 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest August 7, 2024 20:44 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest August 7, 2024 20:44 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest August 7, 2024 20:44 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest August 7, 2024 20:44 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest August 7, 2024 20:44 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest August 7, 2024 20:44 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest August 7, 2024 20:44 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest August 7, 2024 20:44 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest August 7, 2024 20:44 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest August 7, 2024 20:44 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest August 7, 2024 20:44 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest August 7, 2024 20:44 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest August 7, 2024 20:44 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest August 7, 2024 20:44 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest August 7, 2024 20:44 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest August 7, 2024 20:44 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest August 7, 2024 20:44 — with GitHub Actions Inactive
@ruisebas ruisebas temporarily deployed to IntegrationTest August 7, 2024 20:44 — with GitHub Actions Inactive
@ruisebas ruisebas marked this pull request as ready for review August 7, 2024 22:10
@ruisebas ruisebas requested review from awsmobilesdk and a team as code owners August 7, 2024 22:10
@ruisebas ruisebas merged commit bf077f7 into main Aug 8, 2024
67 checks passed
@ruisebas ruisebas deleted the ruisebas/fix_S3_integ branch August 8, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisabhash thisisabhash thisisabhash approved these changes

@awsmobilesdk awsmobilesdk Awaiting requested review from awsmobilesdk awsmobilesdk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruisebas @thisisabhash