Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): fix system header imports #5425

Merged
merged 1 commit into from
Aug 19, 2024
Merged

fix(core): fix system header imports #5425

merged 1 commit into from
Aug 19, 2024

Conversation

thisisabhash
Copy link
Member

Issue #, if available:
#5419

Description of changes:
This change includes fixing import of unistd.h from "unistd.h" to<unistd.h> since it's a system header.

Check points:

  • Added new tests to cover change, if needed
  • All unit tests pass
  • All integration tests pass
  • Updated CHANGELOG.md
  • Documentation update for the change if required
  • PR title conforms to conventional commit style

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@thisisabhash thisisabhash requested review from awsmobilesdk and a team as code owners August 16, 2024 16:56
@lawmicha lawmicha mentioned this pull request Aug 19, 2024
Closed
@thisisabhash thisisabhash merged commit aec8e5c into main Aug 19, 2024
67 checks passed
@thisisabhash thisisabhash deleted the fix/import-system-header branch August 19, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruisebas ruisebas ruisebas approved these changes

@awsmobilesdk awsmobilesdk Awaiting requested review from awsmobilesdk awsmobilesdk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thisisabhash @ruisebas