Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(IoT): Fixing a race condition when invalidating/creating the reconnect timer #5454

Merged
merged 1 commit into from
Dec 10, 2024
Merged

fix(IoT): Fixing a race condition when invalidating/creating the reconnect timer #5454

merged 1 commit into from
Dec 10, 2024

Conversation

sebaland
Copy link
Member

Issue #, if available:

Description of changes:

The reconnectTimer property is created in the timerQueue queue, but it can be invalidated and set to nil in the main queue inside the cleanupReconnectTimer method.

See the issue for a more detailed analysis and explanation by @AndrKonovalov

Check points:

  • Added new tests to cover change, if needed
  • All unit tests pass
  • All integration tests pass
  • Updated CHANGELOG.md
  • Documentation update for the change if required
  • PR title conforms to conventional commit style

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sebaland sebaland requested review from awsmobilesdk and a team as code owners October 25, 2024 21:41
@sebaland sebaland merged commit 582e289 into main Dec 10, 2024
67 checks passed
@sebaland sebaland deleted the fix/iot-crash branch December 10, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harsh62 harsh62 harsh62 approved these changes

@awsmobilesdk awsmobilesdk Awaiting requested review from awsmobilesdk awsmobilesdk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebaland @harsh62