Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(MobileClient): Removing deprecated methods #5459

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

ruisebas
Copy link
Member

@ruisebas ruisebas commented Nov 4, 2024

Issue #, if available:

Description of changes:
Removing the following methods from AWSMobileClient:

  • interceptApplication(_:didFinishLaunchingWithOptions:)
  • interceptApplication(_:didFinishLaunchingWithOptions:resumeSessionWithCompletionHandler:)
  • setSignInProviders(_:)
  • getCredentialsProvider()

These were meant to be removed way back in 2.11.0, but since they still exists in the Objective-C interface they were still accessible.

Check points:

  • Added new tests to cover change, if needed
  • All unit tests pass
  • All integration tests pass
  • Updated CHANGELOG.md
  • Documentation update for the change if required
  • PR title conforms to conventional commit style

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ruisebas
Copy link
Member Author

ruisebas commented Nov 5, 2024

Note: The AWSLex integration is failing because in order to run in Xcode 15 (i.e. the default in macos-13) we need to add a new flag -ld64. But this flag is not available in macos-12.

Because of the pull_request_target trigger, the workflow definition used for the integration tests is the one from main, so until we merge this PR they will still run in macos-12

OTHER_LDFLAGS = "-ObjC";
OTHER_LDFLAGS = (
"-ObjC",
"-ld64",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed for Xcode 15, which is the default now in macos-13

@ruisebas ruisebas marked this pull request as ready for review November 5, 2024 15:32
@ruisebas ruisebas requested review from awsmobilesdk and a team as code owners November 5, 2024 15:32
@harsh62 harsh62 merged commit 49fa47c into main Dec 9, 2024
66 of 67 checks passed
@harsh62 harsh62 deleted the ruisebas/deprecated_awsmobileclient branch December 9, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants