-
Notifications
You must be signed in to change notification settings - Fork 886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(IoT): Fixing a potential race condition in the timer ring queue #5461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruisebas
temporarily deployed
to
IntegrationTest
November 5, 2024 16:32 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
November 5, 2024 16:32 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
November 5, 2024 16:32 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
November 5, 2024 16:32 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
November 5, 2024 16:32 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
November 5, 2024 16:32 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
November 5, 2024 16:32 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
November 5, 2024 16:32 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
November 5, 2024 16:32 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
November 5, 2024 16:32 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
November 5, 2024 16:32 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
November 5, 2024 16:32 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
November 5, 2024 16:32 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
November 5, 2024 16:32 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
November 5, 2024 16:32 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
November 5, 2024 16:32 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
November 5, 2024 16:32 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
November 5, 2024 16:32 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
November 5, 2024 16:32 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
November 5, 2024 16:32 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
November 5, 2024 16:32 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
November 5, 2024 16:32 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
November 5, 2024 16:32 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
November 5, 2024 16:32 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
November 5, 2024 16:32 — with
GitHub Actions
Inactive
harsh62
had a problem deploying
to
IntegrationTest
December 9, 2024 16:12 — with
GitHub Actions
Failure
harsh62
temporarily deployed
to
IntegrationTest
December 9, 2024 16:12 — with
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
December 9, 2024 16:12 — with
GitHub Actions
Inactive
harsh62
temporarily deployed
to
IntegrationTest
December 9, 2024 16:12 — with
GitHub Actions
Inactive
harsh62
approved these changes
Dec 10, 2024
ruisebas
temporarily deployed
to
IntegrationTest
December 10, 2024 20:23 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
December 10, 2024 20:23 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
December 10, 2024 20:23 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
December 10, 2024 20:23 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
December 10, 2024 20:23 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
December 10, 2024 20:23 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
December 10, 2024 20:23 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
December 10, 2024 20:23 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
December 10, 2024 20:23 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
December 10, 2024 20:23 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
December 10, 2024 20:23 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
December 10, 2024 20:23 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
December 10, 2024 20:23 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
December 10, 2024 20:23 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
December 10, 2024 20:23 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
December 10, 2024 20:23 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
December 10, 2024 20:23 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
December 10, 2024 20:23 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
December 10, 2024 20:23 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
December 10, 2024 20:23 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
December 10, 2024 20:23 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
December 10, 2024 20:23 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
December 10, 2024 20:23 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
December 10, 2024 20:23 — with
GitHub Actions
Inactive
ruisebas
temporarily deployed
to
IntegrationTest
December 10, 2024 20:23 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
AWSMQTTSession.timerRing
is aNSArray
with each element being aNSSet
. This can potentially cause a race condition that leads to a crash, if two different threads attempt to access/modify these collections at the same time.I'm creating a new
AWSMQTTTimerRing
class that encapsulates these collections and protects their access with aNSLock
, similar to what I previously did forAWSIoTAtomicDictionary
Check points:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.