Go V2 Controller #64
Go V2 Controller #64
Conversation
rushmash91
force-pushed
the
main
branch
10 times, most recently
from
3285411 to
d5479df
Compare
|
@rushmash91: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| required: | ||
| - executionRoleARN | ||
| - jobDriver | ||
| - releaseLabel | ||
| type: object |
There was a problem hiding this comment.
These fields are still required..code-gen bug?
| if input.ContainerProvider != nil { | ||
| // Clear any existing Info | ||
| if input.ContainerProvider.Info != nil { | ||
| input.ContainerProvider.Info = nil | ||
| } | ||
|
|
||
| // Set the Info field if it exists in the spec | ||
| eksInfo := &svcsdktypes.EksInfo{} | ||
| if desired.ko.Spec.ContainerProvider.Info != nil && | ||
| desired.ko.Spec.ContainerProvider.Info.EKSInfo != nil && | ||
| desired.ko.Spec.ContainerProvider.Info.EKSInfo.Namespace != nil { | ||
| eksInfo.Namespace = desired.ko.Spec.ContainerProvider.Info.EKSInfo.Namespace | ||
| } else { | ||
| eksInfo.Namespace = aws.String("default") | ||
| } | ||
| input.ContainerProvider.Info = &svcsdktypes.ContainerInfoMemberEksInfo{ | ||
| Value: *eksInfo, | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
need to remove this portion after fix
| } | ||
| f0.SetInfo(f0f1) | ||
| f0.Info = f0f1 |
There was a problem hiding this comment.
f0f1 needs to equal f0f1f0Parent..code-gen bug..needs fix in next PR
|
/lgtm |
1 similar comment
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, michaelhtm, rushmash91 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.